Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PD getMembers's timeout duration is not limited by the config. #635

Closed
iosmanthus opened this issue Jul 27, 2022 · 0 comments · Fixed by #636
Closed

PD getMembers's timeout duration is not limited by the config. #635

iosmanthus opened this issue Jul 27, 2022 · 0 comments · Fixed by #636
Assignees
@iosmanthus
Labels
type/bug Something isn't working

Comments

@iosmanthus
Copy link
Member

Bug Report

1. Describe the bug

While disconnecting with the PD servers, the client will not produce a timeout exception in time by the config.

2. Minimal reproduce step (Required)

  1. Launch a workload with tiup playground.
  2. execute shell command: pkill -SIGSTOP pd-server

3. What did you see instead (Required)

Some slow logs report that requests run about 22s, instead of the config duration.

4. What did you expect to see? (Required)

Report timeout in time.

5. What are your Java Client and TiKV versions? (Required)

  • Client Java: 3.3.0 or master
  • TiKV: any version
@iosmanthus iosmanthus added the type/bug Something isn't working label Jul 27, 2022
@iosmanthus iosmanthus changed the title PD getMembers's timeout duration is not limited by the config. PD getMembers's timeout duration is not limited by the config. Jul 27, 2022
@iosmanthus iosmanthus self-assigned this Jul 27, 2022
@iosmanthus iosmanthus mentioned this issue Jul 27, 2022
Merged
iosmanthus added a commit that referenced this issue Jul 27, 2022
@iosmanthus
[close #635] constraint the getMember timeout by inject a backoffer (#…
3128161 
…636)

* constraint the getMember timeout by inject a backoffer

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* fix checkHealth unlimited retry

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* ./dev/javafmt

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* fix unstable test

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* unify default backoffer in tryUpdateLeader

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@ti-srebot ti-srebot mentioned this issue Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iosmanthus iosmanthus

Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[close #635] constraint the getMember timeout by inject a backoffer iosmanthus/client-java
1 participant
@iosmanthus