Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Support API v2 (part 1) #415

Merged
merged 7 commits into from
Aug 30, 2023
Merged

*: Support API v2 (part 1) #415

merged 7 commits into from
Aug 30, 2023

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Aug 15, 2023

Ref: #359

This PR is part of #353 to make the code review easier.

Changes

  • Implement the basic skeleton of codec.
  • Support set api version of API v2 for request context.

Coming PRs

  • Encode request by adding keyspace prefix.
  • Decode response by removing keyspace prefix.
  • PD client interface for keyspace.
  • Unit & integration tests for API v2.

Signed-off-by: Ping Yu <yuping@pingcap.com>
@pingyu pingyu marked this pull request as draft August 15, 2023 13:09
pingyu added 2 commits August 25, 2023 20:28
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
@pingyu pingyu marked this pull request as ready for review August 28, 2023 03:12
pingyu added 3 commits August 28, 2023 11:22
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
@Smityz
Copy link
Contributor

Smityz commented Aug 29, 2023

This is really great, I thought this feature wouldn't be developed before

Signed-off-by: Ping Yu <yuping@pingcap.com>
@pingyu pingyu merged commit 4b0e844 into tikv:master Aug 30, 2023
4 checks passed
andylokandy added a commit to andylokandy/client-rust that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants