Use async/await in the transaction APIs #91
Conversation
After this commit, the library requires a nightly Rust compiler to build. The required toolchain version is also updated in README.md and .travis.yml. Signed-off-by: Yilin Chen <sticnarf@gmail.com>
| @@ -28,8 +28,6 @@ The client requires a Git dependency until we can [publish it](https://github.co | |||
|
|
|||
| There are [examples](examples) which show how to use the client in a Rust program. | |||
|
|
|||
| The examples and documentation use async/await syntax. This is a new feature in Rust and is currently unstable. To use async/await you'll need to add the feature flag `#![async_await]` to your crate and use a nightly compiler (see below). | |||
There was a problem hiding this comment.
Could you alter this comment rather than delete it please? I think it is important for users to know
src/transaction/client.rs
Outdated
| pub fn current_timestamp(&self) -> Timestamp { | ||
| unimplemented!() | ||
| pub async fn current_timestamp(&self) -> Result<Timestamp> { | ||
| Arc::clone(&self.rpc).get_timestamp().await |
There was a problem hiding this comment.
I'm OK with both, but the official doc says "The Arc::clone(&from) syntax is the most idiomatic": https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#cloning-references
There was a problem hiding this comment.
In practice, I don't see the explicit form unless it is necessary for disambiguation (I had a quick search though the Rust repo and although it is hard to tell where .clone is used on an Arc, it does seem to be used more often than the explicit version).
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
|
Previously, CI failed because of a clippy bug. rust-lang/rust-clippy#4266 fixed it. Now, I have upgraded toolchain to latest. |
After this commit, the library requires a nightly Rust compiler to build.
The required toolchain version is also updated in README.md and .travis.yml.