Add more make targets: `clean/no-push-down/push-down-without-v…
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iosmanthus
requested review from
lonng and
breezewish
and removed request for
lonng
breezewish
reviewed
Dec 27, 2019
README.md
Outdated
| @@ -5,8 +5,6 @@ executes TiDB push-down executors to improve performance. | |||
|
|
|||
| ## Push Down Test | |||
|
|
|||
| `./push-down-test` | |||
README.md
Outdated
| @@ -36,7 +34,7 @@ TiDB side for now. | |||
| ### Test Cases | |||
|
|
|||
| We have already added some test cases generated by [randgen] in the push-down-test. Feel free to | |||
| ``` | ||
|
|
||
| If you want to filter some test cases: | ||
|
|
||
| ``` | ||
| include=1_arith_1.sql make push-down-test |
| @@ -1 +0,0 @@ | |||
| /bin/ | |||
There was a problem hiding this comment.
move to push-down-test/build
push-down-test/run-test.sh
Outdated
| @@ -0,0 +1,366 @@ | |||
| # GO environment variables | |||
There was a problem hiding this comment.
revert the rename so that github diff will work
…sh-down-with-vec Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>
iosmanthus
force-pushed
the
split-tests
branch
from
f247772 to
180ea4f
Compare
Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>
breezewish
reviewed
Dec 30, 2019
README.md
Outdated
| @@ -36,7 +34,7 @@ TiDB side for now. | |||
| ### Test Cases | |||
|
|
|||
| We have already added some test cases generated by [randgen] in the push-down-test. Feel free to | |||
| add new ones. Your test case should be placed in the `push-down-test/sql` directory and ends with | |||
| add new ones. Your test case should be placed in the `sql` directory and ends with | |||
| @@ -3,7 +3,7 @@ | |||
| *.swp | |||
| .DS_Store | |||
|
|
|||
| *.log | |||
| **.log | |||
Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>
lonng
reviewed
Dec 30, 2019
push-down-test/run-tests.sh
Outdated
|
|
||
| "$tikv_bin" -C "$push_down_with_batch_config_dir"/tikv.toml --log-file "$tikv_with_batch_log_file" -L ${log_level} & | ||
| tikv_with_batch_pid=$! | ||
| # Return the PID of the new PD process |
There was a problem hiding this comment.
Suggested change
| # Return the PID of the new PD process | |
| # Return the PID of the new TiKV process |
lonng
reviewed
Dec 30, 2019
push-down-test/run-tests.sh
Outdated
| export GO_FAILPOINTS="github.com/pingcap/tidb/expression/PushDownTestSwitcher=return(\"$push_down_func_list\");github.com/pingcap/tidb/expression/PanicIfPbCodeUnspecified=return(true)" | ||
| "$tidb_bin" -log-file "$push_down_with_batch_tidb_log_file" -config "$push_down_with_batch_config_dir"/tidb.toml -L ${log_level} & | ||
| tidb_push_down_with_batch_pid=$! | ||
| # Return the PID of the new PD process |
lonng
reviewed
Dec 30, 2019
push-down-test/run-tests.sh
Outdated
| } | ||
|
|
||
| function build_tester() { | ||
| echo | ||
| echo "+ Building Push Down Tester" | ||
| echo " - Building from ${push_down_test_bin}" | ||
| echo "+Building Push Down Tester" |
There was a problem hiding this comment.
Suggested change
| echo "+Building Push Down Tester" | |
| echo "+ Building Push Down Tester" |
lonng
reviewed
Dec 30, 2019
push-down-test/run-tests.sh
Outdated
|
|
||
| clean_all_proc | ||
| exit $exit_code | ||
|
|
Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>
|
@lonng PTAL |
|
@iosmanthus The prepare step has executed in the run_tests.sh scripts. It's better to remove the prepare logic in |
lonng
approved these changes
Dec 30, 2019
iosmanthus
changed the title
make targets: clean/no-push-down/push-down-without-vec/push-down-with-vec make targets: `clean/no-push-down/push-down-without-v…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests refactor the
copr-testinorder to make reproducing a failed SQL more conveniently.