-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpcio: pre-generate bindings for common targets #356
Conversation
PLTA @BusyJay |
@BusyJay do you have thoughts on #356 (comment) ? |
That's why the bindings are named according to the target platform. It's intended to only maintain limited platform. I agree we should remove the pre-generated bindings when rust-bindgen supports bundled clang. For now, pre-generating seems a more suitable solution. |
Because clang is the default compiler on MacOS, so I drop the support. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Building bindings at compile time introduces extra dependencies. And clang is hard to install and configure on some platform like centos 7. It will be very convenient that we can pre-generate bindings for common targets like x86_64-unknown-linux-gnu. For others, we can fallback to rust-bindgen at compile time.