Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server-side metadata for all call types #555

Merged
merged 42 commits into from
Feb 23, 2022
Merged

Server-side metadata for all call types #555

merged 42 commits into from
Feb 23, 2022

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Jan 21, 2022

This PR continues #543.

@christian-oudard
WIP server side metadata.
07b6cd3 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Fix a borrow checker problem.
dd798d9 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
WIP client side metadata.
a45be2b 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Move BatchResult to being a struct instead of a tuple, so it can impl…
dd84af6 
…ement Unpin.

Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Fix bugs in client side receiving of metadata.
f03199a 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Finish implementation of metadata for unary calls.
11f0bdc 
* Move awaiting of future from ClientUnaryReceiver onto a utility method, .message()
* Fix memory issues with moving metadata out of C++ wrapper.
* Change priority of arguments to grpcwrap_call_send_status_from_server
so that empty metadata is only created if filled metadata is not
present.
* Still need to add back a legacy API so we can still do receiver.await
instead of receiver.message().await.

Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Cargo fmt.
0c3dee8 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Implement moving of metadata out of context object on client side. Th…
c0d388b 
…is segfaults, and needs to be fixed.

Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Revert "Implement moving of metadata out of context object on client …
f53b3a7 
…side. This segfaults, and needs to be fixed."

This reverts commit 4efa018.

Metadata is refcounted internally to the grpc C library, so we can't
move out of the C struct.

Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Fix cloning metadata from raw C struct.
a0fbd5c 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Implement server to client metadata for client-streaming calls.
3e71033 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
WIP
9dd3d42 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Implement server-side metadata for server-streaming and duplex calls.
3e8bd2d 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Add call_flags when sending headers in client-streaming calls.
ffdc245 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Remove send_empty_initial_metadata now that we have a real initial_me…
79fad04 
…tadata argument.

Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Remove spurious "mut".
f906645 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Remove unnecessary clone.
1065180 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Attempt to avoid cloning metadata on client side. This is currently b…
aed0fc4 
…roken, and segfaults.

Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Fix double-free segfault by adding correct refcounting for recv_initi…
62a8627 
…al_metadata.

Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Cargo fmt.
08cf609 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Merge branch 'master' into feature/server-side-metadata
d4831e0 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Cargo fmt again.
ee85deb 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Clippy fixes.
0e8b846 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Allow the server to set call_flags for initial metadata.
fe86f5e 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Another cargo clippy fix.
7c1cd6d 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Update usage of client unary async API in benchmark and interop tests.
0401364 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
More rust fmt fixes.
c90f21a 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Add a utility function to receive headers synchronously.
542d9b6 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Cargo clippy fix.
cf5828b 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Update usage of receiver in unittests.
b4ba7e0 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
christian-oudard and others added 5 commits November 15, 2021 10:15
@christian-oudard
Cargo fmt.
131e16d 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Run codegen.
39afe02 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Minor cleanup.
a6dc944 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@christian-oudard
Remove a stray comment.
2c01a6c 
Signed-off-by: Christian Oudard <christian.oudard@gmail.com>
@BusyJay
address comment
28d056c 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay BusyJay mentioned this pull request Jan 21, 2022
Closed
3 tasks
@BusyJay
Merge branch 'master' into introduce-serverside-metadata-api
9136299 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
fix format
ed8d92a 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@christian-oudard
Copy link
Contributor

Thank you so much for continuing this work, I've been busy with other priorities.

hunterlxt
hunterlxt previously approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@hunterlxt hunterlxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost the same as the original #543 except c++ wrapper.

@BusyJay
keep compatability by reimporting future
3f98b6b 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
add interop case
db3086f 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
format using latest stable rustfmt
b52172d 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
add tests
656c1d3 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
remove unused imports
a6febca 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay BusyJay force-pushed the introduce-serverside-metadata-api branch from 1a7b4cc to a6febca Compare February 22, 2022 10:21
hunterlxt
hunterlxt previously approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@hunterlxt hunterlxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BusyJay BusyJay force-pushed the introduce-serverside-metadata-api branch from d0c62d4 to a6febca Compare February 23, 2022 07:50
@BusyJay BusyJay merged commit 5a7f3ac into tikv:master Feb 23, 2022
@BusyJay BusyJay deleted the introduce-serverside-metadata-api branch February 23, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunterlxt hunterlxt hunterlxt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BusyJay @christian-oudard @hunterlxt