Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the prost service generator available to clients. This allows
clients to customize how the underlying prost build is invoked.
Signed-off-by: Nick Santana nick@mobilecoin.com
name: Publicize Prost Service Generator
about: Makes the prost generator a public struct
Description of feature:
The prost service generator is now public, allowing clients finer grain control on the prost build behavior.
Implementation:
The initial desire for this was to allow us to build just the services, while re-using the messages. The current
grpcio_compiler::prost_codegen::compile_protos()
function would either fail to build when local protos were excluded from the include path, or generate the local proto messages to the generated services.Making the
Generator
public seemed like the best way to meet this current need and also allow future customers to customize the prost build behavior while still generating the grpcio services.Expanding the availability of the
Generator
looks to be limited to making theServiceGenerator
trait methods also available. It doesn't seem to be exposing anything else from the internals.Checklist:
The CI will check all of these, but you'll need to have done them:
cargo fmt -- --check
passes.cargo +nightly clippy
has no warnings.cargo test
passes.