Fix unknown log file and module #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
tonyxuqqi
approved these changes
Jul 19, 2023
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
BusyJay
reviewed
Jul 19, 2023
| @@ -30,9 +30,9 @@ extern "C" fn delegate(c_args: *mut gpr_log_func_args) { | |||
| &Record::builder() | |||
| .args(format_args!("{msg}")) | |||
| .level(level) | |||
| .file(file_str.into()) | |||
| .file_static(file_str.into()) | |||
There was a problem hiding this comment.
yes, file name is generated by macro, see https://github.com/tikv/grpc/blob/996605a5e62f3f00043ac8d3ebca84523bc2dd76/include/grpc/impl/codegen/log.h#L55
BusyJay
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs are always with unknown file name when redirecting logs to
slog, seeIt's because slog would only take static str into account
https://github.com/slog-rs/stdlog/blob/252b6bb6435a8a3ba44748b2e1626aa676508097/lib.rs#L73
With this fix, the file name is not unknown anymore
