bin: inline tikv::binutil::* so that CARGO_PKG_VERSION is the correct version #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
status/PTAL
kennytm
force-pushed
the
kennytm/extract-version-print
branch
from
ba91f85 to
d614319
Compare
kennytm
changed the title
Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
force-pushed
the
kennytm/extract-version-print
branch
from
d614319 to
9b554dd
Compare
|
/release |
kennytm
added
status/LGT1
breezewish
approved these changes
Aug 6, 2019
kennytm
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Inline the content of this file: https://github.com/tikv/tikv/blob/v3.0.2/src/binutil/mod.rs - into
src/bin/tikv-importer.rsso thatenv!("CARGO_PKG_VERSION")returns the version of TiKV Importer instead of the TiKV dependency.What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Does this PR affect TiDB Lightning? (mandatory)
No
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)