Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: use peer_address to resolve rpc channel #50

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Bug Fix: use peer_address to resolve rpc channel #50

merged 3 commits into from
Mar 20, 2020

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Mar 19, 2020

What have you changed? (mandatory)

  • Fix bug: should use peer_address resolve rpc channel if target is tiflash store.

What are the type of the changes? (mandatory)

How has this PR been tested? (mandatory)

  • manual

Does this PR affect TiDB Lightning? (mandatory)

  • support tidb-lightning for tiflash store

solotzg and others added 2 commits March 19, 2020 21:45
@solotzg
use peer addr to resolve
a6ee0dd 
Signed-off-by: Tong Zhigao <tongzhigao@pingcap.com>
@solotzg
Merge branch 'master' into bug-fix-peer-addr
9f6351b
kennytm
kennytm reviewed Mar 19, 2020
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 One reviewer already commented LGTM (LGTM1) label Mar 19, 2020
@kennytm
Copy link
Collaborator

kennytm commented Mar 19, 2020

/test

@kennytm kennytm added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Mar 20, 2020
@kennytm kennytm merged commit d6d4fb4 into tikv:master Mar 20, 2020
@solotzg solotzg deleted the bug-fix-peer-addr branch March 20, 2020 07:00
kennytm pushed a commit that referenced this pull request Apr 20, 2020
@solotzg @IANTHEREAL
use peer addr to resolve (#50) (#57)
ecb0add 
Signed-off-by: Tong Zhigao <tongzhigao@pingcap.com>

Co-authored-by: Ian <ArGregoryIan@gmail.com>

Co-authored-by: Ian <ArGregoryIan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@overvenus overvenus overvenus approved these changes

Assignees
No one assigned
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@solotzg @kennytm @overvenus @IANTHEREAL