*: Use lower version of openssl and make more functions async #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kennytm <kennytm@gmail.com>
|
LGTM |
kennytm
force-pushed
the
use-lower-version-of-openssl
branch
2 times, most recently
from
6ec1628 to
d218600
Compare
Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
force-pushed
the
use-lower-version-of-openssl
branch
11 times, most recently
from
43d7860 to
bb5cc92
Compare
Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
force-pushed
the
use-lower-version-of-openssl
branch
from
bb5cc92 to
c00f0fe
Compare
kennytm
changed the title
|
Blocked by cherry-pick of tikv/tikv#9390 to release-5.0-rc. |
Signed-off-by: kennytm <kennytm@gmail.com>
Signed-off-by: kennytm <kennytm@gmail.com>
|
/cc @glorv @overvenus |
|
/run-all-test |
zhangjinpeng87
approved these changes
Dec 30, 2020
|
/merge |
jebter
approved these changes
Dec 30, 2020
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
1. Use the same locked OpenSSL version as TiKV (1.1.1g) instead of the latest one (1.1.1i)
Fix this error when connecting to importer:
We may need to check the cert generation algorithm in Lightning to ensure nothing goes wrong when we actually upgrade OpenSSL to 1.1.1i.
2. Make more functions relying on
block_onas async, to avoid theEnterErrorwhen usingblock_oninside an async context.What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
run the Lightning integration test
various_types.Does this PR affect TiDB Lightning? (mandatory)
No
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)