Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: Add https for tikv sink #232

Closed
zeminzhou opened this issue Sep 19, 2022 · 0 comments · Fixed by #233
Closed

cdc: Add https for tikv sink #232

zeminzhou opened this issue Sep 19, 2022 · 0 comments · Fixed by #233
Assignees
@zeminzhou

Comments

@zeminzhou
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

Add https for tikv sink.

Describe the feature you'd like:

Support https for tikv sink.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:
@zeminzhou zeminzhou self-assigned this Sep 19, 2022
@zeminzhou zeminzhou mentioned this issue Sep 19, 2022
Merged
pingyu added a commit that referenced this issue Sep 22, 2022
@zeminzhou @pingyu
[close #232] Add https for tikv sink (#233)
1b6667f 
* add https for tikv-sink

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* fix ut

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* fix comment

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* fix comment

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* remove len check

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* add https for tikv-sink

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* .

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* fix check

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Co-authored-by: Ping Yu <yuping@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeminzhou zeminzhou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[close #232] Add https for tikv sink zeminzhou/migration
1 participant
@zeminzhou