[close #128] Fix TestClientErrNoPendingRegion #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pingyu yuping@pingcap.com
What problem does this PR solve?
Issue Number: close #128
Problem Description:
clientSuite.TestClientErrNoPendingRegion
is not stable.What is changed and how does it work?
Make test cases in
clientSuite
be serial.Move
baseAllocatedID
to be acquired beforeEventFeed
goroutine to ensure the correctness of base value.Note that I'm not sure this PR will fix the issue. Although I re-run the CI and all of them are successful. If the failure happen again, reopen the issue.
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes