Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #128] Fix TestClientErrNoPendingRegion #127

Merged
merged 3 commits into from
Jun 17, 2022

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Jun 16, 2022

Signed-off-by: pingyu yuping@pingcap.com

What problem does this PR solve?

Issue Number: close #128

Problem Description: clientSuite.TestClientErrNoPendingRegion is not stable.

What is changed and how does it work?

Make test cases in clientSuite be serial.
Move baseAllocatedID to be acquired before EventFeed goroutine to ensure the correctness of base value.

Note that I'm not sure this PR will fix the issue. Although I re-run the CI and all of them are successful. If the failure happen again, reopen the issue.

Code changes

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test

Side effects

Related changes

Signed-off-by: pingyu <yuping@pingcap.com>
@pingyu pingyu changed the title [close #?][WIP] fix TestClientErrNoPendingRegion [close #?][DNM] fix TestClientErrNoPendingRegion Jun 16, 2022
Signed-off-by: pingyu <yuping@pingcap.com>
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #127 (c75a763) into main (b3c6c9b) will decrease coverage by 0.0813%.
The diff coverage is n/a.

❗ Current head c75a763 differs from pull request most recent head 104d12e. Consider uploading reports for the commit 104d12e to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##               main       #127        +/-   ##
================================================
- Coverage   59.4629%   59.3815%   -0.0814%     
================================================
  Files           167        167                
  Lines         13294      13324        +30     
================================================
+ Hits           7905       7912         +7     
- Misses         4811       4834        +23     
  Partials        578        578                
Flag Coverage Δ
cdc 59.3815% <ø> (-0.0814%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdc/pkg/retry/retry_with_opt.go 90.9090% <0.0000%> (-4.5455%) ⬇️
cdc/cdc/kv/client.go 84.2029% <0.0000%> (-2.1740%) ⬇️
cdc/cdc/http_router.go 81.4814% <0.0000%> (-0.8715%) ⬇️

@pingyu pingyu changed the title [close #?][DNM] fix TestClientErrNoPendingRegion [close #128] Fix TestClientErrNoPendingRegion Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc: unit test clientSuite.TestClientErrNoPendingRegion is not stable
3 participants