[fix #246] fix unified sorter #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
|
PTAL~ |
pingyu
reviewed
Oct 9, 2022
cdc/cdc/puller/puller.go
Outdated
| @@ -231,6 +227,7 @@ func (p *pullerImpl) Run(ctx context.Context) error { | |||
| if err != nil { | |||
| return errors.Trace(err) | |||
| } | |||
| metricTxnCollectCounterResolved.Inc() | |||
There was a problem hiding this comment.
Suggest:
- Rename to
metricPullOutputCounterResolved. So as to the underlying prom metric name. - Utilize
kvEventCounteras the puller input counter. The input & output metrics will help us determine whether there is issue in puller module. For both kv & resolved-ts event. - Add the input counter to grafana panel.
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
================================================
- Coverage 61.2425% 61.0307% -0.2119%
================================================
Files 238 239 +1
Lines 20200 20180 -20
================================================
- Hits 12371 12316 -55
- Misses 6690 6743 +53
+ Partials 1139 1121 -18
*This pull request uses carry forward flags. Click here to find out more.
|
zeminzhou
force-pushed
the
fix-sort
branch
2 times, most recently
from
7536910 to
87d8293
Compare
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
haojinming
reviewed
Oct 9, 2022
cdc/metrics/grafana/tikv-cdc.json
Outdated
| @@ -6496,100 +6496,6 @@ | |||
| "alignLevel": null | |||
| } | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Removing a panel will leave a blank space, may need move all other panels or modify the metric json in next pr?
There was a problem hiding this comment.
yesh, it will leave a blank space. I add it back, and remove it in next pr. Thanks
pingyu
reviewed
Oct 9, 2022
|
|
added, thanks |
pingyu
pushed a commit
to pingyu/tikv-migration
that referenced
this pull request
Oct 9, 2022
* fix unified sorter Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * remove debug log Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * add metric for the input event of puller Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * remove puller input metric Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * add back Signed-off-by: zeminzhou <zhouzemin@pingcap.com> Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
pingyu
pushed a commit
to pingyu/tikv-migration
that referenced
this pull request
Oct 9, 2022
* fix unified sorter Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * remove debug log Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * add metric for the input event of puller Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * remove puller input metric Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * add back Signed-off-by: zeminzhou <zhouzemin@pingcap.com> Signed-off-by: zeminzhou <zhouzemin@pingcap.com> Signed-off-by: pingyu <yuping@pingcap.com>
pingyu
added a commit
that referenced
this pull request
Oct 9, 2022
* [fix #246] fix unified sorter (#247) * fix unified sorter Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * remove debug log Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * add metric for the input event of puller Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * remove puller input metric Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * add back Signed-off-by: zeminzhou <zhouzemin@pingcap.com> Signed-off-by: zeminzhou <zhouzemin@pingcap.com> Signed-off-by: pingyu <yuping@pingcap.com> * fix keyspan sink metrics (#249) Signed-off-by: pingyu <yuping@pingcap.com> Signed-off-by: pingyu <yuping@pingcap.com> * fix gh action Signed-off-by: pingyu <yuping@pingcap.com> Signed-off-by: zeminzhou <zhouzemin@pingcap.com> Signed-off-by: pingyu <yuping@pingcap.com> Co-authored-by: zzm <zhouzemin@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zeminzhou zhouzemin@pingcap.com
What problem does this PR solve?
puller output resolvedtsIssue Number: close #246
Problem Description: TBD
What is changed and how does it work?
remove
wrong printCode changes
Check List for Tests
This PR has been tested by at least one of the following methods: