remove some unused code (#3363)

Signed-off-by: rleungx <rleungx@gmail.com>
tikv · Jan 18, 2021 · 02c5f77 · 02c5f77
1 parent 5f447ae
commit 02c5f77
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/pkg/movingaverage/time_median.go b/pkg/movingaverage/time_median.go
@@ -20,7 +20,6 @@ import "time"
 // Delay is aotSize * mfSize * reportInterval/4
 // and the min filled period is aotSize * reportInterval, which is not related with mfSize
 type TimeMedian struct {
-	aotInterval   time.Duration
 	aot           *AvgOverTime
 	mf            *MedianFilter
 	aotSize       int
@@ -31,11 +30,10 @@ type TimeMedian struct {
 // NewTimeMedian returns a TimeMedian with given size.
 func NewTimeMedian(aotSize, mfSize int, reportInterval time.Duration) *TimeMedian {
 	return &TimeMedian{
-		aotInterval: reportInterval,
-		aot:         NewAvgOverTime(time.Duration(aotSize) * reportInterval),
-		mf:          NewMedianFilter(mfSize),
-		aotSize:     aotSize,
-		mfSize:      mfSize,
+		aot:     NewAvgOverTime(time.Duration(aotSize) * reportInterval),
+		mf:      NewMedianFilter(mfSize),
+		aotSize: aotSize,
+		mfSize:  mfSize,
 	}
 }
 

diff --git a/server/statistics/hot_peer_cache.go b/server/statistics/hot_peer_cache.go
@@ -377,7 +377,7 @@ func (f *hotPeerCache) getDefaultTimeMedian() *movingaverage.TimeMedian {
 }
 
 func (f *hotPeerCache) updateHotPeerStat(newItem, oldItem *HotPeerStat, bytes, keys float64, interval time.Duration) *HotPeerStat {
-	if newItem == nil || newItem.needDelete {
+	if newItem.needDelete {
 		return newItem
 	}