Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD HTTP API self-protection #4207

Closed
Tracked by #4373
nolouch opened this issue Oct 13, 2021 · 6 comments
Closed
Tracked by #4373

PD HTTP API self-protection #4207

nolouch opened this issue Oct 13, 2021 · 6 comments
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@nolouch
Copy link
Contributor

nolouch commented Oct 13, 2021

Feature Request

Describe your feature request related problem

PD is the most important metadata service center of the cluster, and it also includes TSO services. PD needs to have certain self-protection capabilities, among which, we need to limit the access rate of some heavy APIs. here, we focus HTTP API first.

Describe the feature you'd like

Consider add middleware, use ratelimiter to limit the rate of the HeavyAPIs request, such as /hotspot/regions/history

Teachability, Documentation, Adoption, Migration Strategy

@nolouch nolouch added the type/enhancement The issue or PR belongs to an enhancement. label Oct 13, 2021
@nolouch
Copy link
Contributor Author

nolouch commented Oct 25, 2021

/assign @qidi1

@ti-chi-bot
Copy link
Member

@nolouch: GitHub didn't allow me to assign the following users: qidi1.

Note that only tikv members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @qidi1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qidi1 added a commit to IcePigZDB/pd that referenced this issue Oct 25, 2021
Signed-off-by: qidi1 <1083369179@qq.com>
qidi1 added a commit to IcePigZDB/pd that referenced this issue Oct 25, 2021
Signed-off-by: qidi1 <1083369179@qq.com>
@rleungx
Copy link
Member

rleungx commented Nov 24, 2021

/assign @CabinfeverB

@ti-chi-bot
Copy link
Member

@rleungx: GitHub didn't allow me to assign the following users: CabinfeverB.

Note that only tikv members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @CabinfeverB

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CabinfeverB
Copy link
Member

/assign

@CabinfeverB
Copy link
Member

refer #4480, Closed since most tasks has been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants