Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output panic log to pd.log #6257

Closed
Lily2025 opened this issue Apr 3, 2023 · 4 comments · Fixed by #6325
Closed

output panic log to pd.log #6257

Lily2025 opened this issue Apr 3, 2023 · 4 comments · Fixed by #6325
Assignees
@HuSharp
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@Lily2025
Copy link

Lily2025 commented Apr 3, 2023

Bug Report

What did you do?

no mater

What did you expect to see?

output panic log to pd.log

What did you see instead?

no panic log in pd.log if pd panic

What version of PD are you using (pd-server -V)?
@Lily2025 Lily2025 added the type/bug The issue is confirmed as a bug. label Apr 3, 2023
@Lily2025
Copy link
Author

Lily2025 commented Apr 3, 2023

/type enhancement
/assign HuSharp

@ti-chi-bot
Copy link
Member

@Lily2025: GitHub didn't allow me to assign the following users: HuSharp.

Note that only tikv members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/type enhancement
/assign HuSharp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the type/enhancement The issue or PR belongs to an enhancement. label Apr 3, 2023
@Lily2025
Copy link
Author

Lily2025 commented Apr 3, 2023

/remove-type bug

@ti-chi-bot ti-chi-bot removed the type/bug The issue is confirmed as a bug. label Apr 3, 2023
@HuSharp
Copy link
Member

HuSharp commented Apr 3, 2023

/assign

@rleungx rleungx mentioned this issue Apr 14, 2023
Merged
ti-chi-bot pushed a commit that referenced this issue Apr 17, 2023
@rleungx
*: fix the missing log panic (#6325)
0e42a50 
close #6257

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HuSharp HuSharp

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: fix the missing log panic rleungx/pd
3 participants
@HuSharp @ti-chi-bot @Lily2025