Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: deleted scheduler is not synced to scheduling server #7169

Closed
lhy1024 opened this issue Sep 27, 2023 · 0 comments · Fixed by #7236
Closed

mcs: deleted scheduler is not synced to scheduling server #7169

lhy1024 opened this issue Sep 27, 2023 · 0 comments · Fixed by #7236
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 27, 2023

Enhancement Task

I try add some tests, but failed

// Fixme: the following code will fail because the scheduler is not removed but not synced.
// checkDelete := func(schedulerName string) {
// re.NotNil(schedulersController.GetScheduler(schedulers.BalanceLeaderName) != nil)
// api.MustDeleteScheduler(re, suite.backendEndpoints, schedulers.BalanceLeaderName)
// testutil.Eventually(re, func() bool {
// return schedulersController.GetScheduler(schedulers.BalanceLeaderName) == nil
// })
// }
// checkDelete(schedulers.BalanceLeaderName)
// checkDelete(schedulers.BalanceRegionName)
// checkDelete(schedulers.HotRegionName)

@lhy1024 lhy1024 added the type/enhancement The issue or PR belongs to an enhancement. label Sep 27, 2023
ti-chi-bot bot pushed a commit that referenced this issue Oct 20, 2023
#7236)

close #7169

Fix the default scheduler initialization of the scheduling service.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Dec 1, 2023
tikv#7236)

close tikv#7169

Fix the default scheduler initialization of the scheduling service.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant