Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use instance label wisely to optimize the presentation of Grafana #7583

Closed
CabinfeverB opened this issue Dec 20, 2023 · 0 comments · Fixed by #7619
Closed

Use instance label wisely to optimize the presentation of Grafana #7583

CabinfeverB opened this issue Dec 20, 2023 · 0 comments · Fixed by #7619
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@CabinfeverB
Copy link
Member

CabinfeverB commented Dec 20, 2023 •
edited
Loading

Enhancement Task

After the microservices were implemented, the instance variable was removed from Grafana so that metrics for different instances could be displayed on the same page.
But this brings some issues:

  1. The pd server does not reset metrics immediately after panic occurs. As a result, the monitored items using the sum function become larger such as For some Gauge metrics items, max should be used #7506.
  2. We support gRPC forwarding, which also causes the QPS we see to be higher than the actual one.
  3. We will support the follower handle of gRPC and HTTP. We need to monitor QPS according to the instance.

In addition, the current panel ID allocation is very confusing, which is very inconvenient when we want to create a new panel
@CabinfeverB CabinfeverB added the type/enhancement The issue or PR belongs to an enhancement. label Dec 20, 2023
@CabinfeverB CabinfeverB mentioned this issue Dec 20, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Dec 20, 2023
@CabinfeverB @ti-chi-bot
grafana: reassign the ID of the panel (#7588)
84e60be 
ref #7583

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@CabinfeverB CabinfeverB mentioned this issue Dec 25, 2023
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #7619 Jan 8, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jan 8, 2024
@CabinfeverB
metrics: add instance var and improve conccurrency metrics (#7619)
33a0d94 
close #7583

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
pingandb pushed a commit to pingandb/pd that referenced this issue Jan 18, 2024
@CabinfeverB @pingandb
metrics: add instance var and improve conccurrency metrics (tikv#7619)
3b8a4ca 
close tikv#7583

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: pingandb <songge102@pingan.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics: add instance var and improve conccurrency metrics CabinfeverB/pd
1 participant
@CabinfeverB