Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misuse of trace region in tso_dispatcher #8534

Closed
zyguan opened this issue Aug 15, 2024 · 1 comment · Fixed by #8847
Closed

Misuse of trace region in tso_dispatcher #8534

zyguan opened this issue Aug 15, 2024 · 1 comment · Fixed by #8847
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 severity/moderate type/bug The issue is confirmed as a bug.

Comments

@zyguan
Copy link

zyguan commented Aug 15, 2024

pd/client/tso_dispatcher.go

Lines 413 to 415 in 1b8fc6a

for i := range traceRegions {
traceRegions[i].End()
}

Here Region.End should be called in reversed order, otherwise, it makes trace out broken.

2024-08-15_154136
@ti-chi-bot ti-chi-bot bot added the needs-type Indicates an issue requires a type label. label Aug 15, 2024
@zyguan
Copy link
Author

zyguan commented Aug 15, 2024

/type bug

@ti-chi-bot ti-chi-bot bot added type/bug The issue is confirmed as a bug. and removed needs-type Indicates an issue requires a type label. labels Aug 15, 2024
zyguan added a commit to zyguan/pd that referenced this issue Sep 4, 2024
@zyguan
fix tikv#8534
77b4024 
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@ti-chi-bot ti-chi-bot bot added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 1, 2024
@rleungx rleungx mentioned this issue Nov 25, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Nov 25, 2024
@rleungx @ti-chi-bot
client: fix trace (#8847)
52b42b2 
close #8534

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Need Triage to Closed in Questions and Bug Reports Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 severity/moderate type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client: fix trace rleungx/pd
3 participants
@jebter @zyguan @rleungx