Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the doc 'development-workflow.md' #1464

Merged
merged 3 commits into from
Mar 20, 2019
Merged

added the doc 'development-workflow.md' #1464

merged 3 commits into from
Mar 20, 2019

Conversation

elitecodegroovy
Copy link
Contributor

What problem does this PR solve?

The document can help contributor how to do development workflow.

What is changed and how it works?

I just added a document and update the document CONTRIBUTING.md.

@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@elitecodegroovy
Copy link
Contributor Author

What problem does this PR solve?

The document can help contributor how to do development workflow.

What is changed and how it works?

I just added a document and update the document CONTRIBUTING.md.

In order to solve the issue that the Contributor License Agreement is not signed by superadmin account, I open the new PR. So please close the up PR *:added the doc 'development-workflow.md'

@codecov-io
Copy link

Codecov Report

Merging #1464 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1464      +/-   ##
==========================================
- Coverage    67.8%   67.63%   -0.17%     
==========================================
  Files         158      158              
  Lines       15262    15262              
==========================================
- Hits        10348    10323      -25     
- Misses       4003     4019      +16     
- Partials      911      920       +9
Impacted Files Coverage Δ
server/leader.go 82.35% <0%> (-5.89%) ⬇️
server/util.go 72.97% <0%> (-4.73%) ⬇️
server/etcd_kv.go 70.9% <0%> (-3.64%) ⬇️
server/core/kv.go 76.47% <0%> (-1.48%) ⬇️
server/option.go 90.41% <0%> (-0.84%) ⬇️
server/grpc_service.go 53.66% <0%> (-0.48%) ⬇️
client/client.go 68.53% <0%> (-0.24%) ⬇️
server/cluster.go 78.81% <0%> (+0.56%) ⬆️
server/api/redirector.go 84.21% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59968e1...95a04b0. Read the comment docs.

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! And I leave some comments here.

docs/development-workflow.md Outdated Show resolved Hide resolved
docs/development-workflow.md Outdated Show resolved Hide resolved
docs/development-workflow.md Outdated Show resolved Hide resolved
docs/development-workflow.md Outdated Show resolved Hide resolved
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

docs/development-workflow.md Show resolved Hide resolved
@nolouch
Copy link
Contributor

nolouch commented Mar 20, 2019

/rebuild

@rleungx rleungx merged commit e1c1ae4 into tikv:master Mar 20, 2019
@rleungx
Copy link
Member

rleungx commented Mar 20, 2019

@elitecodegroovy Thanks. Merged

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants