-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the doc 'development-workflow.md' #1464
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
1 similar comment
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
In order to solve the issue that the Contributor License Agreement is not signed by superadmin account, I open the new PR. So please close the up PR |
Codecov Report
@@ Coverage Diff @@
## master #1464 +/- ##
==========================================
- Coverage 67.8% 67.63% -0.17%
==========================================
Files 158 158
Lines 15262 15262
==========================================
- Hits 10348 10323 -25
- Misses 4003 4019 +16
- Partials 911 920 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! And I leave some comments here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM.
/rebuild |
@elitecodegroovy Thanks. Merged |
What problem does this PR solve?
The document can help contributor how to do development workflow.
What is changed and how it works?
I just added a document and update the document CONTRIBUTING.md.