*: fix CI and switch to golangci-lint #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rleungx <rleungx@gmail.com>
rleungx
requested review from
disksing and
nolouch
and removed request for
disksing
|
/rebuild |
1 similar comment
|
/rebuild |
nolouch
approved these changes
Mar 21, 2019
|
Why |
|
@disksing I think it might be related to https://golang.org/doc/go1.12#gocache, but I'm not pretty sure. |
disksing
approved these changes
Mar 21, 2019
bradyjoestar
added a commit
to bradyjoestar/pd
that referenced
this pull request
Mar 24, 2019
fix CI and switch to golangci-lint (tikv#1471)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, our CI is not stable. And also
gometalinterandmegacheckare deprecated.What is changed and how it works?
This PR fixes CI by adding
export GO111MODULE=onand switches togolangci-lint.Check List
Tests