Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: check replica for hot region #1609

Merged
merged 4 commits into from
Jul 5, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 2, 2019

What problem does this PR solve?

We don't check the number of replicas when scheduling the hot region.

What is changed and how it works?

This PR improves it by checking if it is lack of replicas or has learner peer, just like the balance region does.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release notes

@rleungx rleungx added needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. labels Jul 2, 2019
@rleungx rleungx requested review from nolouch and disksing July 2, 2019 07:25
@rleungx rleungx removed the needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. label Jul 3, 2019
rleungx added 3 commits July 4, 2019 16:09
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the check-replica-hot-region branch from a84c083 to b4bbebc Compare July 4, 2019 08:10
@nolouch nolouch merged commit f662591 into tikv:master Jul 5, 2019
rleungx added a commit to rleungx/pd that referenced this pull request Jul 10, 2019
* check replica for hot region scheduler

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx mentioned this pull request Jul 10, 2019
4 tasks
nolouch pushed a commit that referenced this pull request Jul 11, 2019
* schedulers: balance region consider pending peer (#1617)

* schedulers: balance region consider pending peers

Signed-off-by: nolouch <nolouch@gmail.com>

* scheduler: check replica for hot region  (#1609)

* check replica for hot region scheduler

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* schedule: set influence according to region size (#1613)

* not consider store limit when executing merge

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* set influence according to region size

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* fix race problems

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* config: turn the default limit of the hot region schedule (#1616)

* config: turn the default limit of the hot region schedule

Signed-off-by: nolouch <nolouch@gmail.com>

* update CHANGELOG

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants