Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: use an individual package for leader #1668

Merged
merged 3 commits into from
Aug 15, 2019
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 6, 2019

What problem does this PR solve?

Part of modularizing PD. It should be reviewed after #1662 is merged.

What is changed and how it works?

This PR uses an individual package for leader.

Check List

Tests

  • Unit test

server/server.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #1668 into master will increase coverage by 0.13%.
The diff coverage is 82.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
+ Coverage   76.52%   76.66%   +0.13%     
==========================================
  Files         157      157              
  Lines       15352    15392      +40     
==========================================
+ Hits        11748    11800      +52     
+ Misses       2587     2579       -8     
+ Partials     1017     1013       -4
Impacted Files Coverage Δ
server/util.go 65.67% <ø> (ø) ⬆️
server/api/redirector.go 78.94% <100%> (ø) ⬆️
pkg/testutil/testutil.go 93.75% <100%> (+8.03%) ⬆️
tests/cluster.go 85.99% <100%> (-0.34%) ⬇️
server/testutil.go 91.3% <100%> (-0.37%) ⬇️
server/grpc_service.go 59.74% <75%> (+0.64%) ⬆️
server/member/leader.go 80.09% <80.09%> (ø)
server/server.go 82.31% <83.47%> (+1.12%) ⬆️
server/api/member.go 61.6% <85.71%> (ø) ⬆️
pkg/metricutil/metricutil.go 90.62% <0%> (-9.38%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e2588...a9ab057. Read the comment docs.

@nolouch nolouch added the priority/P1 The issue has P1 priority. label Aug 15, 2019
Copy link
Contributor

@shafreeck shafreeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added the status/can-merge Indicates a PR has been approved by a committer. label Aug 15, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 15, 2019

/run-all-tests

@sre-bot sre-bot merged commit 00ca522 into tikv:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P1 The issue has P1 priority. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants