*: add test for online reload new TLS certificates #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2162 +/- ##
=========================================
Coverage ? 76.14%
=========================================
Files ? 195
Lines ? 20604
Branches ? 0
=========================================
Hits ? 15689
Misses ? 3726
Partials ? 1189
Continue to review full report at Codecov.
|
nolouch
added
the
needs-cherry-pick-release-3.1
disksing
reviewed
Feb 27, 2020
| @@ -260,7 +260,7 @@ func (c *baseClient) getOrCreateGRPCConn(addr string) (*grpc.ClientConn, error) | |||
| tlsCfg, err := grpcutil.SecurityConfig{ | |||
| CAPath: c.security.CAPath, | |||
| CertPath: c.security.CertPath, | |||
| KeyPath: c.security.CertPath, | |||
| KeyPath: c.security.KeyPath, | |||
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
changed the title
disksing
approved these changes
Feb 27, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.1 in PR #2165 |
nolouch
pushed a commit
that referenced
this pull request
Feb 27, 2020
july2993
added a commit
to pingcap/tidb-binlog
that referenced
this pull request
Mar 15, 2020
we can make sure the version after this tikv/pd#2162 can support reload new TLS certificates. we just pass the file path into the client, the reload is supported by the client internally. https://github.com/pingcap/pd/blob/0f3272c9b0ef661bdaea7f4ed66b13955c503b72/client/client.go#L129
nolouch
added
needs-cherry-pick-release-3.0
|
/run-cherry-picker |
|
cherry pick to release-3.0 failed |
nolouch
pushed a commit
to nolouch/pd
that referenced
this pull request
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
ref pingcap/tidb#14666, #2112
If the key/cert expired, we need to reload it online. the method same as etcd, it is already supported, this PR is to add a test.
What is changed and how it works?
add test verify it.
Check List
Tests