-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: support get default config #2258
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #2258 +/- ##
==========================================
+ Coverage 76.53% 76.57% +0.04%
==========================================
Files 199 199
Lines 21522 21529 +7
==========================================
+ Hits 16472 16486 +14
Misses 3826 3826
+ Partials 1224 1217 -7
Continue to review full report at Codecov.
|
/merge |
/run-all-tests |
What problem does this PR solve?
TiDB dashboard needs to get the default config to compare with the existed config.
What is changed and how it works?
This PR adds API
pd/api/v1/config/default
to get the default config.Check List
Tests
Release note
adds API
pd/api/v1/config/default
to get the default config.