metrics: update monitoring template in grafana #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added
component/metrics
lhy1024
reviewed
May 22, 2020
rleungx
reviewed
May 22, 2020
rleungx
reviewed
May 22, 2020
| "timeFrom": null, | ||
| "timeRegions": [], | ||
| "timeShift": null, | ||
| "title": "Direction of hotspot move leader", |
There was a problem hiding this comment.
The direction is only in hot write row.
There was a problem hiding this comment.
yes. I think it's about the total hot region rather than hot read or hot write. But I cannot find a suitable place.
Signed-off-by: nolouch <nolouch@gmail.com>
|
/approve |
HunDunDM
approved these changes
May 22, 2020
rleungx
approved these changes
May 22, 2020
|
/approve |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #2448 |
jebter
added a commit
that referenced
this pull request
May 25, 2020
* metrics: update json template in grafana Signed-off-by: nolouch <nolouch@gmail.com> * address comments Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com> Co-authored-by: jebter <jebter@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
update_kvandupdate_cacheWhat is changed and how it works?
Update
promQLCheck List
Tests
Release note