Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard,config: support dashboard dynamic public path prefix #2454

Merged
merged 8 commits into from
May 26, 2020

Conversation

TennyZhuang
Copy link
Contributor

What problem does this PR solve?

Resolve pingcap/tidb-dashboard#480

What is changed and how it works?

  1. Upgrade tidb-dashboard.
  2. Add PublicPathPrefix config.
  3. copy assetfs in tidb-dashboard.

Check List

Tests

Code changes

  • Has configuration change

Side effects

Related changes

Release note

support dashboard dynamic public path prefix

@CLAassistant
Copy link

CLAassistant commented May 25, 2020

CLA assistant check
All committers have signed the CLA.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label May 25, 2020
Signed-off-by: Breezewish <me@breeswish.org>
@breezewish breezewish merged commit 3587582 into tikv:master May 26, 2020
@breezewish breezewish deleted the dashboard-dynamic-prefix branch May 26, 2020 11:08
breezewish added a commit that referenced this pull request May 26, 2020
Signed-off-by: Breezewish <me@breeswish.org>
jebter pushed a commit that referenced this pull request May 27, 2020
* Cherry pick #2454

Signed-off-by: Breezewish <me@breeswish.org>

* Add TiDB Dashboard configurations

Signed-off-by: Breezewish <me@breeswish.org>

* Fix race

Signed-off-by: Breezewish <me@breeswish.org>

* Cherry pick #2460

Signed-off-by: Breezewish <me@breeswish.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UCP: Support customizing URL prefix
5 participants