-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add new region score formula #3269
Conversation
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Codecov Report
@@ Coverage Diff @@
## master #3269 +/- ##
==========================================
- Coverage 73.90% 73.85% -0.05%
==========================================
Files 242 242
Lines 23004 23029 +25
==========================================
+ Hits 17001 17009 +8
- Misses 4426 4431 +5
- Partials 1577 1589 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: disksing <i@disksing.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, do we need to add some test result in this pr desc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ok, I'll add a short description. |
/run-all-tests |
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
Make region score grow smoother and less affected by available changes.
What is changed and how it works?
Default formula for newly created clusters is "v2", all old clusters keeps "v1" unless set manually.
The test result shows that compared to v4.0.7, the new formula can help balance fast to converge and more stable even with a very high store limit configuration.
Check List
Tests
Related Issue
Release note