Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id: fix the bug that id may be duplicated (#3322) #3323

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3322 to release-4.0


Signed-off-by: Zheng Xiangsheng hundundm@gmail.com

What problem does this PR solve?

What is changed and how it works?

  • id: fix the bug that id may be duplicated

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix The PR is a bug fix. type/cherry-pick labels Jan 4, 2021
@ti-srebot ti-srebot added this to the v4.0.9 milestone Jan 4, 2021
@ti-srebot
Copy link
Contributor Author

@HunDunDM you're already a collaborator in bot's repo.

@nolouch nolouch modified the milestones: v4.0.9, v4.0.10 Jan 4, 2021
@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #3323 (3033a48) into release-4.0 (7b36ffc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #3323      +/-   ##
===============================================
+ Coverage        74.71%   74.72%   +0.01%     
===============================================
  Files              209      209              
  Lines            19628    19628              
===============================================
+ Hits             14666    14668       +2     
+ Misses            3638     3631       -7     
- Partials          1324     1329       +5     
Flag Coverage Δ
unittests 74.72% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/id/id.go 85.71% <100.00%> (+9.52%) ⬆️
server/heartbeat_streams.go 65.93% <0.00%> (-6.60%) ⬇️
server/region_syncer/client.go 78.74% <0.00%> (-4.73%) ⬇️
server/tso/tso.go 77.53% <0.00%> (-2.90%) ⬇️
server/core/storage.go 67.88% <0.00%> (-0.92%) ⬇️
server/grpc_service.go 59.27% <0.00%> (-0.61%) ⬇️
server/server.go 73.30% <0.00%> (-0.50%) ⬇️
server/handler.go 44.27% <0.00%> (-0.50%) ⬇️
server/cluster/cluster.go 79.57% <0.00%> (-0.13%) ⬇️
client/client.go 69.03% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b36ffc...3033a48. Read the comment docs.

@HunDunDM
Copy link
Member

HunDunDM commented Jan 5, 2021

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3033a48

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2021
@ti-chi-bot ti-chi-bot merged commit b720955 into tikv:release-4.0 Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix The PR is a bug fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants