Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade go.etcd.io/bbolt to fix panic in unit test with go1.14 (#2690) #3331

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 5, 2021

cherry-pick #2690 to release-4.0


Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

Fix panic in unit test with go >= 1.14. ref: etcd-io/bbolt#201

What is changed and how it works?

Replace etcd-io/bbolt version to the latest one.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has go.mod change

Release note

  • No release note

@sre-bot
Copy link
Contributor

sre-bot commented Jan 5, 2021

Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jan 5, 2021

@HunDunDM
Copy link
Member

HunDunDM commented Jan 5, 2021

/rebuild

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #3331 (2cacf67) into release-4.0 (b720955) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #3331      +/-   ##
===============================================
- Coverage        74.84%   74.77%   -0.08%     
===============================================
  Files              209      209              
  Lines            19628    19628              
===============================================
- Hits             14691    14676      -15     
- Misses            3619     3623       +4     
- Partials          1318     1329      +11     
Flag Coverage Δ
unittests 74.77% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/tempurl/tempurl.go 60.00% <0.00%> (-10.00%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
pkg/mock/mockhbstream/mockhbstream.go 88.88% <0.00%> (-3.71%) ⬇️
pkg/etcdutil/etcdutil.go 82.35% <0.00%> (-2.95%) ⬇️
server/server.go 72.80% <0.00%> (-1.83%) ⬇️
server/grpc_service.go 59.07% <0.00%> (-1.21%) ⬇️
server/core/storage.go 67.88% <0.00%> (-0.92%) ⬇️
server/cluster/cluster.go 79.20% <0.00%> (-0.50%) ⬇️
client/client.go 69.54% <0.00%> (ø)
server/tso/tso.go 78.98% <0.00%> (+1.44%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b720955...2cacf67. Read the comment docs.

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 5, 2021
@Yisaer
Copy link
Contributor

Yisaer commented Jan 5, 2021

/merge

@ti-chi-bot
Copy link
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot
Copy link
Member

@Yisaer: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@HunDunDM HunDunDM added component/misc Some other things. type/bug-fix The PR is a bug fix. type/cherry-pick require-LGT1 Indicates that the PR requires an LGTM. labels Jan 5, 2021
@nolouch
Copy link
Contributor

nolouch commented Jan 5, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2cacf67

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2021
@HunDunDM HunDunDM added this to the v4.0.10 milestone Jan 5, 2021
@ti-chi-bot ti-chi-bot merged commit f42cd28 into tikv:release-4.0 Jan 5, 2021
@JmPotato JmPotato deleted the release-4.0-2908a9202d30 branch January 5, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/misc Some other things. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix The PR is a bug fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants