checker: update TTL according to SplitMergeInterval

[rleungx]

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Close #4614.

What is changed and how it works?

Update TTL when split-merge-interval is changed.

Check List

Tests

• Unit test

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JmPotato
• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #4616 (0c7a59f) into master (a6f72df) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 0c7a59f differs from pull request most recent head eb30f41. Consider uploading reports for the commit eb30f41 to get more accurate results

@@            Coverage Diff             @@
##           master    #4616      +/-   ##
==========================================
+ Coverage   74.75%   74.84%   +0.08%     
==========================================
  Files         282      281       -1     
  Lines       27765    27714      -51     
==========================================
- Hits        20757    20743      -14     
+ Misses       5140     5122      -18     
+ Partials     1868     1849      -19     

Flag	Coverage Δ
unittests	74.84% <100.00%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/cache/ttl.go	97.93% <100.00%> (+0.16%)	⬆️
server/schedule/checker/merge_checker.go	73.55% <100.00%> (+0.22%)	⬆️
server/api/unsafe_operation.go	55.55% <0.00%> (-16.67%)	⬇️
server/schedulers/shuffle_hot_region.go	55.55% <0.00%> (-10.11%)	⬇️
pkg/etcdutil/etcdutil.go	82.35% <0.00%> (-3.53%)	⬇️
server/api/router.go	97.32% <0.00%> (-2.24%)	⬇️
server/schedule/operator_controller.go	82.92% <0.00%> (-2.04%)	⬇️
server/member/member.go	64.70% <0.00%> (-1.61%)	⬇️
server/storage/hot_region_storage.go	78.73% <0.00%> (-1.15%)	⬇️
server/schedule/operator/step.go	73.09% <0.00%> (-1.10%)	⬇️
... and 27 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f72df...eb30f41. Read the comment docs.

[nolouch]

lgtm

[lhy1024]

How about judging based on the configured time rather than using the fixed time?

[rleungx]

/hold

[rleungx]

/hold cancel

[lhy1024]

How about judging based on the configured time rather than using the fixed time?

After discussion, it may be difficult to do GC.

[nolouch]

/merge

[ti-chi-bot]

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 0c7a59f