Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: allows to skip placement rules checks (#5458) #5460

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5458

What problem does this PR solve?

Issue Number: Close #5401

What is changed and how does it work?

Allows skipping placement rules checks when creating operators.

Check List

Tests

  • Unit test

Code changes

Related changes

  • Need to cherry-pick to the release branch

Release note

Fixed the bug where the Learner Peer of TiFlash Replica might not be created.

close tikv#5401

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 31, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/schedule Scheduling logic. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick. labels Aug 31, 2022
@ti-chi-bot ti-chi-bot requested review from rleungx and Yisaer August 31, 2022 07:21
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 74.84% // Head: 74.94% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (47fc6dc) compared to base (c7dcc3c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-5.2    #5460      +/-   ##
===============================================
+ Coverage        74.84%   74.94%   +0.10%     
===============================================
  Files              249      249              
  Lines            25765    25766       +1     
===============================================
+ Hits             19283    19311      +28     
+ Misses            4786     4768      -18     
+ Partials          1696     1687       -9     
Flag Coverage Δ
unittests 74.94% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/operator/builder.go 88.00% <100.00%> (+0.02%) ⬆️
server/schedule/operator/create_operator.go 90.15% <100.00%> (ø)
server/kv/etcd_kv.go 79.71% <0.00%> (-5.80%) ⬇️
pkg/dashboard/adapter/manager.go 79.78% <0.00%> (-5.32%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/member/member.go 63.10% <0.00%> (-2.14%) ⬇️
client/base_client.go 82.29% <0.00%> (-2.09%) ⬇️
server/schedule/operator_controller.go 83.56% <0.00%> (-1.99%) ⬇️
server/config/persist_options.go 92.69% <0.00%> (-0.77%) ⬇️
server/cluster/cluster.go 82.01% <0.00%> (-0.36%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2022
@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 47fc6dc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2022
@ti-chi-bot ti-chi-bot merged commit ba7f7e8 into tikv:release-5.2 Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/schedule Scheduling logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants