Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_manager: persist settings with settings prefix #5826

Merged
merged 5 commits into from
Jan 6, 2023

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jan 4, 2023

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Issue Number: Ref #5784

What is changed and how does it work?

resource_manager: persist settings with settings prefix

Check List

Tests

  • Unit test
  • Integration test
None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 4, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 4, 2023
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 4, 2023
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2023
@nolouch nolouch force-pushed the manager/settings branch 2 times, most recently from 8530b11 to db64770 Compare January 5, 2023 07:55
Signed-off-by: nolouch <nolouch@gmail.com>
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 75.58% // Head: 75.71% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (06bb3fb) compared to base (f8c0612).
Patch coverage: 68.29% of modified lines in pull request are covered.

❗ Current head 06bb3fb differs from pull request most recent head 9831a3c. Consider uploading reports for the commit 9831a3c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5826      +/-   ##
==========================================
+ Coverage   75.58%   75.71%   +0.12%     
==========================================
  Files         338      338              
  Lines       33591    33592       +1     
==========================================
+ Hits        25389    25433      +44     
+ Misses       6019     5990      -29     
+ Partials     2183     2169      -14     
Flag Coverage Δ
unittests 75.71% <68.29%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mcs/resource_manager/server/token_bukets.go 39.13% <0.00%> (-3.73%) ⬇️
pkg/mcs/resource_manager/server/manager.go 69.49% <33.33%> (ø)
pkg/mcs/resource_manager/server/resource_group.go 60.95% <80.00%> (ø)
pkg/storage/endpoint/resource_group.go 100.00% <100.00%> (ø)
server/region_syncer/server.go 81.86% <0.00%> (-4.40%) ⬇️
pkg/id/id.go 83.05% <0.00%> (-3.39%) ⬇️
server/schedulers/random_merge.go 62.50% <0.00%> (-3.13%) ⬇️
pkg/encryption/key_manager.go 70.11% <0.00%> (-1.60%) ⬇️
server/server.go 75.00% <0.00%> (-0.77%) ⬇️
server/statistics/store_collection.go 93.75% <0.00%> (-0.63%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nolouch
Copy link
Contributor Author

nolouch commented Jan 5, 2023

PTAL @JmPotato

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 6, 2023
@nolouch
Copy link
Contributor Author

nolouch commented Jan 6, 2023

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9831a3c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2023
@ti-chi-bot ti-chi-bot merged commit c6528a4 into tikv:master Jan 6, 2023
@nolouch nolouch deleted the manager/settings branch January 12, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants