-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource_manager: persist settings with settings prefix #5826
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: nolouch <nolouch@gmail.com>
078e805
to
f65ad52
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
8530b11
to
db64770
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
db64770
to
57e9aef
Compare
Codecov ReportBase: 75.58% // Head: 75.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5826 +/- ##
==========================================
+ Coverage 75.58% 75.71% +0.12%
==========================================
Files 338 338
Lines 33591 33592 +1
==========================================
+ Hits 25389 25433 +44
+ Misses 6019 5990 -29
+ Partials 2183 2169 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
PTAL @JmPotato |
Signed-off-by: nolouch <nolouch@gmail.com>
06bb3fb
to
9831a3c
Compare
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 9831a3c
|
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Issue Number: Ref #5784
What is changed and how does it work?
Check List
Tests