-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource_manager: implement the metrics info collecting #5855
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
Codecov ReportBase: 75.35% // Head: 75.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5855 +/- ##
==========================================
+ Coverage 75.35% 75.41% +0.06%
==========================================
Files 340 341 +1
Lines 34290 34339 +49
==========================================
+ Hits 25838 25898 +60
+ Misses 6225 6213 -12
- Partials 2227 2228 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
747fff3
to
038ce39
Compare
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can send consumption to consumptionDispatcher
passing by AcquireTokenBuckets
Signed-off-by: JmPotato <ghzpotato@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Signed-off-by: JmPotato <ghzpotato@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: ec501e7
|
Signed-off-by: JmPotato ghzpotato@gmail.com
What problem does this PR solve?
Issue Number: ref #5854.
What is changed and how does it work?
Check List
Tests
Release note