Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: increase InitClusterRegionThreshold #5943

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 8, 2023

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Ref #5944.

What is changed and how does it work?

Right now, the newly created cluster has 51 regions, which exceeds the threshold. In the future, we need to find a better way to represent the newly created cluster.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the increase-threshold branch from 8c99deb to cf32ebd Compare February 8, 2023 10:23
@rleungx rleungx requested review from bufferflies and JmPotato and removed request for Yisaer February 8, 2023 10:37
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 75.57% // Head: 75.49% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (cf32ebd) compared to base (5811b9f).
Patch has no changes to coverable lines.

❗ Current head cf32ebd differs from pull request most recent head f623723. Consider uploading reports for the commit f623723 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5943      +/-   ##
==========================================
- Coverage   75.57%   75.49%   -0.09%     
==========================================
  Files         346      346              
  Lines       35184    35184              
==========================================
- Hits        26591    26561      -30     
- Misses       6309     6326      +17     
- Partials     2284     2297      +13     
Flag Coverage Δ
unittests 75.49% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/core/region.go 89.21% <ø> (ø)
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
pkg/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
pkg/storage/endpoint/meta.go 63.63% <0.00%> (-4.55%) ⬇️
pkg/tso/tso.go 70.78% <0.00%> (-2.81%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
pkg/tso/allocator_manager.go 62.74% <0.00%> (-1.78%) ⬇️
pkg/encryption/key_manager.go 70.11% <0.00%> (-1.60%) ⬇️
server/schedule/operator/step.go 76.62% <0.00%> (-0.68%) ⬇️
server/server.go 75.15% <0.00%> (-0.51%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2023
@nolouch
Copy link
Contributor

nolouch commented Feb 8, 2023

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cf32ebd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@ti-chi-bot ti-chi-bot merged commit e14a985 into tikv:master Feb 8, 2023
@rleungx rleungx deleted the increase-threshold branch February 9, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants