-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: increase InitClusterRegionThreshold
#5943
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
2bf9c48
to
ed897d9
Compare
ed897d9
to
8c99deb
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
8c99deb
to
cf32ebd
Compare
Codecov ReportBase: 75.57% // Head: 75.49% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5943 +/- ##
==========================================
- Coverage 75.57% 75.49% -0.09%
==========================================
Files 346 346
Lines 35184 35184
==========================================
- Hits 26591 26561 -30
- Misses 6309 6326 +17
- Partials 2284 2297 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: cf32ebd
|
Signed-off-by: Ryan Leung rleungx@gmail.com
What problem does this PR solve?
Issue Number: Ref #5944.
What is changed and how does it work?
Right now, the newly created cluster has 51 regions, which exceeds the threshold. In the future, we need to find a better way to represent the newly created cluster.
Check List
Tests
Release note