Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: introduce the cluster informer for decoupling the dependencies #6489

Merged
merged 3 commits into from
May 22, 2023
Merged

*: introduce the cluster informer for decoupling the dependencies #6489

merged 3 commits into from
May 22, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented May 19, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Part of #6418.

Check List

Tests

  • Unit test

Release note

None.

@rleungx
introduce the cluster informer for decoupling the dependencies
5054d41 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 19, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 19, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and HunDunDM May 19, 2023 06:14
@rleungx rleungx requested review from JmPotato and CabinfeverB and removed request for disksing and HunDunDM May 19, 2023 06:15
@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 73.91% and project coverage change: -0.04 ⚠️

Comparison is base (b2275f6) 75.00% compared to head (3b18d11) 74.96%.

❗ Current head 3b18d11 differs from pull request most recent head 5c118a7. Consider uploading reports for the commit 5c118a7 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6489      +/-   ##
==========================================
- Coverage   75.00%   74.96%   -0.04%     
==========================================
  Files         410      410              
  Lines       41892    41893       +1     
==========================================
- Hits        31420    31405      -15     
- Misses       7703     7722      +19     
+ Partials     2769     2766       -3
Flag Coverage Δ
unittests 74.96% <73.91%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/keyspace/keyspace.go 61.75% <ø> (ø)
pkg/schedule/checker/checker_controller.go 80.00% <ø> (ø)
pkg/schedule/checker/joint_state_checker.go 57.89% <ø> (ø)
pkg/schedule/checker/learner_checker.go 72.72% <ø> (ø)
pkg/schedule/checker/merge_checker.go 70.99% <ø> (ø)
pkg/schedule/checker/priority_inspector.go 81.08% <ø> (ø)
pkg/schedule/checker/replica_checker.go 67.80% <ø> (ø)
pkg/schedule/checker/replica_strategy.go 86.00% <ø> (ø)
pkg/schedule/checker/rule_checker.go 82.41% <ø> (ø)
pkg/schedule/checker/split_checker.go 68.18% <ø> (ø)
... and 32 more

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rleungx rleungx mentioned this pull request May 19, 2023
Merged
@rleungx rleungx requested a review from nolouch May 19, 2023 06:58
nolouch
nolouch reviewed May 22, 2023
View reviewed changes
pkg/keyspace/keyspace.go Outdated
"github.com/tikv/pd/pkg/schedule/labeler"
"github.com/tikv/pd/pkg/schedule/scheduling"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

schedule
schedule/scheduling
schedulers

will it be too much schedule?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. but I don't have a better idea about the naming.

Copy link
Contributor

@nolouch nolouch May 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about change

scheduling -> runtime or core
schedulers -> strategies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I change scheduling to core and keep the scheduler as it is.

lhy1024
lhy1024 approved these changes May 22, 2023
View reviewed changes
pkg/schedule/scheduling/cluster_informer.go Outdated
@@ -1,4 +1,4 @@
// Copyright 2017 TiKV Project Authors.
// Copyright 2020 TiKV Project Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change it?

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 22, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 22, 2023
@rleungx rleungx requested a review from nolouch May 22, 2023 09:01
@rleungx
address the comment
3b18d11 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the cluster-informer branch from 8c7123c to 3b18d11 Compare May 22, 2023 09:02
@rleungx
Copy link
Member Author

rleungx commented May 22, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 22, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 3b18d11

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 22, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 22, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 4725351 into tikv:master May 22, 2023
@rleungx rleungx deleted the cluster-informer branch May 22, 2023 09:41
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@rleungx
*: put the operator related logic together (#6490)
a14f38f 
ref #5839, ref #6418, ref #6489

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx mentioned this pull request May 26, 2023
Closed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx @ti-chi-bot
*: introduce the cluster informer for decoupling the dependencies (ti…
02eb14e 
…kv#6489)

ref tikv#5839, ref tikv#6418

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx
*: put the operator related logic together (tikv#6490)
ea92cba 
ref tikv#5839, ref tikv#6418, ref tikv#6489

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato JmPotato approved these changes

@CabinfeverB CabinfeverB Awaiting requested review from CabinfeverB

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rleungx @JmPotato @nolouch @lhy1024