Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedule: use a controller to manage schedulers #6773

Merged
merged 3 commits into from
Jul 10, 2023
Merged

schedule: use a controller to manage schedulers #6773

merged 3 commits into from
Jul 10, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 7, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

This PR introduces a controller to manage the schedulers and decouple the dependencies with the coordinator. Need to merge #6771 first.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 7, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and Yisaer July 7, 2023 04:18
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 7, 2023
@rleungx rleungx requested review from JmPotato and nolouch and removed request for disksing and Yisaer July 7, 2023 04:19
@rleungx rleungx mentioned this pull request Jul 7, 2023
Closed
@rleungx rleungx force-pushed the scheduler-controller branch 2 times, most recently from 80294d2 to 6f2971f Compare July 7, 2023 05:30
@rleungx rleungx mentioned this pull request Jul 7, 2023
Merged
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #6773 (6f2971f) into master (c87782a) will increase coverage by 0.11%.
The diff coverage is 73.71%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6773      +/-   ##
==========================================
+ Coverage   74.18%   74.29%   +0.11%     
==========================================
  Files         411      413       +2     
  Lines       43126    43183      +57     
==========================================
+ Hits        31992    32082      +90     
+ Misses       8265     8238      -27     
+ Partials     2869     2863       -6
Flag Coverage Δ
unittests 74.29% <73.71%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

rleungx added 2 commits July 10, 2023 12:44
@rleungx
refactor diagnostic manager
39f49be 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
use a controller to manage schedulers
bd99c75 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the scheduler-controller branch from 6f2971f to bd99c75 Compare July 10, 2023 04:47
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 10, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 10, 2023
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 10, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 10, 2023

This pull request has been accepted and is ready to merge.

Commit hash: bd99c75

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 10, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 10, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

nolouch
nolouch approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/schedule/schedulers/scheduler_controller.go
}

// GetWaitGroup returns the waitGroup of the controller.
func (c *Controller) GetWaitGroup() *sync.WaitGroup {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what not directly Wait()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it in the next PR.

@ti-chi-bot ti-chi-bot bot merged commit 5759daf into tikv:master Jul 10, 2023
@rleungx rleungx deleted the scheduler-controller branch July 10, 2023 09:59
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx @ti-chi-bot
schedule: use a controller to manage schedulers (tikv#6773)
706a7b3 
ref tikv#5839

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rleungx @JmPotato @nolouch @CabinfeverB