mcs: init HTTP handler #6963
mcs: init HTTP handler #6963
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/XXL
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6963 +/- ##
==========================================
+ Coverage 74.21% 74.25% +0.04%
==========================================
Files 433 433
Lines 46137 46046 -91
==========================================
- Hits 34240 34193 -47
+ Misses 8871 8847 -24
+ Partials 3026 3006 -20
Flags with carried forward coverage won't be shown. Click here to find out more. |
cmd/pd-server/main.go
Outdated
| @@ -41,6 +41,11 @@ import ( | |||
| "github.com/tikv/pd/server/config" | |||
| "github.com/tikv/pd/server/join" | |||
| "go.uber.org/zap" | |||
|
|
|||
| // register microservice HTTP API | |||
| _ "github.com/tikv/pd/pkg/mcs/resourcemanager/server/apis/v1" | |||
There was a problem hiding this comment.
why need this? Does install pkg duplicate with it?
There was a problem hiding this comment.
If we don't import, the independent service cannot use the HTTP interface in the current implementation. There is an import cycle problem.
There was a problem hiding this comment.
I mean why not
_ "github.com/tikv/pd/pkg/mcs/resourcemanager/server/install"
_ "github.com/tikv/pd/pkg/mcs/scheduling/server/install"
_ "github.com/tikv/pd/pkg/mcs/tso/server/apis/install"
make http and grpc register togeter. Does it exist import cycle? I think it's same with xxx/api.
ti-chi-bot
bot
added
status/LGT2
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
/merge |
|
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 57125f6
|
ti-chi-bot
bot
added
the
status/can-merge
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref tikv#5839 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Ref #5839.
What is changed and how does it work?
Need to merge #6960 first.
Check List
Tests
Release note