mcs: support changing log level #7172
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #7172 +/- ##
==========================================
- Coverage 74.58% 74.52% -0.07%
==========================================
Files 441 441
Lines 47292 47347 +55
==========================================
+ Hits 35275 35286 +11
- Misses 8940 8964 +24
- Partials 3077 3097 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -129,6 +130,17 @@ func (s *Server) RegisterGRPCService(grpcServer *grpc.Server) { | |||
| s.service.RegisterGRPCService(grpcServer) | |||
| } | |||
|
|
|||
| // SetLogLevel sets log level. | |||
| func (s *Server) SetLogLevel(level string) error { | |||
There was a problem hiding this comment.
Will we support it in pd-ctl?
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: ec5757a
|
ti-chi-bot
bot
added
the
status/can-merge
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref tikv#5839 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Ref #5839.
What is changed and how does it work?
This PR supports changing log level by sending a HTTP request, e.g.,
curl -X PUT http://10.2.8.101:2388/scheduling/api/v1/admin/log -H 'Content-Type: application/json' --data '"debug"'Check List
Tests
Release note