Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs/scheduling: fix typo #7333

Merged
merged 2 commits into from
Nov 8, 2023
Merged

mcs/scheduling: fix typo #7333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29ae29e
fix typo
CabinfeverB Nov 8, 2023
839b9d9
Merge branch 'master' into mcs/scheduling/fix_typo
ti-chi-bot[bot] Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/mcs/scheduling/server/grpc_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ type Service struct {
*Server
}

// NewService creates a new TSO service.
// NewService creates a new scheduling service.
func NewService[T ConfigProvider](svr bs.Server) registry.RegistrableService {
server, ok := svr.(*Server)
if !ok {
Expand Down Expand Up @@ -118,7 +118,7 @@ func (s *heartbeatServer) Recv() (*schedulingpb.RegionHeartbeatRequest, error) {
return req, nil
}

// RegionHeartbeat implements gRPC PDServer.
// RegionHeartbeat implements gRPC SchedulingServer.
func (s *Service) RegionHeartbeat(stream schedulingpb.Scheduling_RegionHeartbeatServer) error {
var (
server = &heartbeatServer{stream: stream}
Expand Down Expand Up @@ -168,7 +168,7 @@ func (s *Service) RegionHeartbeat(stream schedulingpb.Scheduling_RegionHeartbeat
}
}

// StoreHeartbeat implements gRPC PDServer.
// StoreHeartbeat implements gRPC SchedulingServer.
func (s *Service) StoreHeartbeat(ctx context.Context, request *schedulingpb.StoreHeartbeatRequest) (*schedulingpb.StoreHeartbeatResponse, error) {
c := s.GetCluster()
if c == nil {
Expand Down Expand Up @@ -202,7 +202,7 @@ func (s *Service) SplitRegions(ctx context.Context, request *schedulingpb.SplitR
}, nil
}

// ScatterRegions implements gRPC PDServer.
// ScatterRegions implements gRPC SchedulingServer.
func (s *Service) ScatterRegions(ctx context.Context, request *schedulingpb.ScatterRegionsRequest) (*schedulingpb.ScatterRegionsResponse, error) {
c := s.GetCluster()
if c == nil {
Expand Down Expand Up @@ -261,7 +261,7 @@ func (s *Service) GetOperator(ctx context.Context, request *schedulingpb.GetOper
}, nil
}

// AskBatchSplit implements gRPC PDServer.
// AskBatchSplit implements gRPC SchedulingServer.
func (s *Service) AskBatchSplit(ctx context.Context, request *schedulingpb.AskBatchSplitRequest) (*schedulingpb.AskBatchSplitResponse, error) {
c := s.GetCluster()
if c == nil {
Expand Down
Loading