Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourcemanager: return resource-group priority in OnRequestWait #7378

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Nov 16, 2023

What problem does this PR solve?

Issue Number: close #7379, ref tikv/tikv#15994

What is changed and how does it work?

return resource-group priority in OnRequestWait so client-go can set the resource-group priority to kv request.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

None

Signed-off-by: glorv <glorvs@163.com>
Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and Yisaer November 16, 2023 02:50
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. do-not-merge/needs-linked-issue and removed do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed labels Nov 16, 2023
@glorv
Copy link
Contributor Author

glorv commented Nov 16, 2023

@nolouch @CabinfeverB PTAL

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #7378 (5b74603) into master (0ebf4b2) will increase coverage by 0.08%.
Report is 1 commits behind head on master.
The diff coverage is 80.00%.

❗ Current head 5b74603 differs from pull request most recent head 0064eac. Consider uploading reports for the commit 0064eac to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7378      +/-   ##
==========================================
+ Coverage   74.18%   74.27%   +0.08%     
==========================================
  Files         451      451              
  Lines       48877    48877              
==========================================
+ Hits        36261    36302      +41     
+ Misses       9390     9350      -40     
+ Partials     3226     3225       -1     
Flag Coverage Δ
unittests 74.27% <80.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 16, 2023
@CabinfeverB
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 5b74603

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 16, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

@glorv: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 4e600c2 into tikv:master Nov 16, 2023
22 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #7383.

@glorv glorv deleted the group-priority branch November 16, 2023 03:57
ti-chi-bot bot pushed a commit that referenced this pull request Nov 16, 2023
…) (#7383)

close #7379, ref tikv/tikv#15994

Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow return resource group priority in resource interceptor
4 participants