Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

election: provide methods to read and write campaignTimes instead of export #7501

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Dec 6, 2023

What problem does this PR solve?

Issue Number: ref #7499.

What is changed and how does it work?

Provide methods to read and write `campaignTimes` instead of export.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added require-LGT1 Indicates that the PR requires an LGTM. component/election Election related logic. labels Dec 6, 2023
@JmPotato JmPotato requested a review from HuSharp December 6, 2023 14:51
Copy link
Contributor

ti-chi-bot bot commented Dec 6, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2023
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #7501 (f638b43) into master (4eac0ef) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7501   +/-   ##
=======================================
  Coverage   74.56%   74.56%           
=======================================
  Files         452      452           
  Lines       49934    49928    -6     
=======================================
- Hits        37234    37230    -4     
+ Misses       9377     9376    -1     
+ Partials     3323     3322    -1     

@JmPotato
Copy link
Member Author

JmPotato commented Dec 7, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f638b43

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 6080557 into tikv:master Dec 7, 2023
26 checks passed
@JmPotato JmPotato deleted the refine_campaign_times branch December 7, 2023 01:25
@JmPotato JmPotato restored the refine_campaign_times branch December 13, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/election Election related logic. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants