Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

member, server: randomly check the etcd leader health to proactively resign #7661

Closed
wants to merge 2 commits into from

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jan 4, 2024

What problem does this PR solve?

Issue Number: ref #7499.

What is changed and how does it work?

Randomly check the etcd leader health to proactively resign.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

@JmPotato JmPotato added the component/election Election related logic. label Jan 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 4, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

ti-chi-bot bot commented Jan 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Jan 4, 2024
@ti-chi-bot ti-chi-bot bot requested review from disksing and rleungx January 4, 2024 07:35
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 4, 2024
@JmPotato JmPotato force-pushed the watch_etcd_health branch 3 times, most recently from 223de1e to 6bb51cf Compare January 4, 2024 08:24
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #7661 (0bfaa4d) into master (754095a) will increase coverage by 0.01%.
Report is 11 commits behind head on master.
The diff coverage is 89.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7661      +/-   ##
==========================================
+ Coverage   73.87%   73.89%   +0.01%     
==========================================
  Files         429      429              
  Lines       47376    47415      +39     
==========================================
+ Hits        35000    35038      +38     
+ Misses       9392     9384       -8     
- Partials     2984     2993       +9     
Flag Coverage Δ
unittests 73.89% <89.74%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2024
@JmPotato JmPotato force-pushed the watch_etcd_health branch 2 times, most recently from 168d597 to ea1d4b9 Compare January 4, 2024 09:19
@JmPotato JmPotato marked this pull request as ready for review January 4, 2024 09:19
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2024
@JmPotato JmPotato requested review from HuSharp and removed request for disksing January 4, 2024 09:20
@JmPotato
Copy link
Member Author

JmPotato commented Jan 4, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Member Author

JmPotato commented Jan 4, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2024
@JmPotato JmPotato closed this Jan 30, 2024
@JmPotato JmPotato deleted the watch_etcd_health branch January 30, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/election Election related logic. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant