Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: prevent suddenly scheduling #7714

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 16, 2024

What problem does this PR solve?

Issue Number: Ref #7671.

What is changed and how does it work?

Previous change is not enough, since there are hibernated regions. 1 minute cannot prevent the sudden scheduling.

Check List

Tests

  • Manual test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jan 16, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and nolouch January 16, 2024 06:56
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jan 16, 2024
@rleungx rleungx requested a review from HuSharp January 16, 2024 06:58
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Merging #7714 (e22d222) into master (3a12148) will increase coverage by 0.11%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7714      +/-   ##
==========================================
+ Coverage   73.74%   73.85%   +0.11%     
==========================================
  Files         429      429              
  Lines       47496    47498       +2     
==========================================
+ Hits        35027    35082      +55     
+ Misses       9472     9438      -34     
+ Partials     2997     2978      -19     
Flag Coverage Δ
unittests 73.85% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 16, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 16, 2024
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the prevent-scheduling branch from b21a599 to 1bca504 Compare January 16, 2024 07:23
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the prevent-scheduling branch from 73fe9bf to da7d32c Compare January 16, 2024 09:17
@rleungx
Copy link
Member Author

rleungx commented Jan 17, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2024

This pull request has been accepted and is ready to merge.

Commit hash: da7d32c

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 6472313 into tikv:master Jan 17, 2024
23 of 26 checks passed
@rleungx rleungx deleted the prevent-scheduling branch January 17, 2024 04:26
rleungx added a commit to rleungx/pd that referenced this pull request Jan 25, 2024
* etcdutil, mcs: fix the issue loading label rules is too slow (tikv#7718)

Signed-off-by: lhy1024 <admin@liudos.us>

* ci: run `make check` with longer timeout (tikv#7271)

ref tikv#4399

Signed-off-by: lhy1024 <admin@liudos.us>

* mcs: add a switch to dynamically enable scheduling service (tikv#7595)

ref tikv#5839

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* schedule: prevent suddenly scheduling (tikv#7714)

ref tikv#7671

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* makefile: update golangci (tikv#7556)

close tikv#7551

Signed-off-by: husharp <jinhao.hu@pingcap.com>

* fix conflict

Signed-off-by: lhy1024 <admin@liudos.us>

---------

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Co-authored-by: Ryan Leung <rleungx@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: Hu# <jinhao.hu@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants