-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule: prevent suddenly scheduling #7714
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7714 +/- ##
==========================================
+ Coverage 73.74% 73.85% +0.11%
==========================================
Files 429 429
Lines 47496 47498 +2
==========================================
+ Hits 35027 35082 +55
+ Misses 9472 9438 -34
+ Partials 2997 2978 -19
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ryan Leung <rleungx@gmail.com>
b21a599
to
1bca504
Compare
73fe9bf
to
da7d32c
Compare
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: da7d32c
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
* etcdutil, mcs: fix the issue loading label rules is too slow (tikv#7718) Signed-off-by: lhy1024 <admin@liudos.us> * ci: run `make check` with longer timeout (tikv#7271) ref tikv#4399 Signed-off-by: lhy1024 <admin@liudos.us> * mcs: add a switch to dynamically enable scheduling service (tikv#7595) ref tikv#5839 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * schedule: prevent suddenly scheduling (tikv#7714) ref tikv#7671 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * makefile: update golangci (tikv#7556) close tikv#7551 Signed-off-by: husharp <jinhao.hu@pingcap.com> * fix conflict Signed-off-by: lhy1024 <admin@liudos.us> --------- Signed-off-by: lhy1024 <admin@liudos.us> Signed-off-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: Hu# <jinhao.hu@pingcap.com>
What problem does this PR solve?
Issue Number: Ref #7671.
What is changed and how does it work?
Previous change is not enough, since there are hibernated regions. 1 minute cannot prevent the sudden scheduling.
Check List
Tests
Release note