Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: API bench supports etcd #7715

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Conversation

CabinfeverB
Copy link
Member

What problem does this PR solve?

Issue Number: Close #7703

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 16, 2024
@ti-chi-bot ti-chi-bot bot requested review from disksing and Yisaer January 16, 2024 07:25
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Merging #7715 (c4227e1) into master (567c7d4) will increase coverage by 0.24%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7715      +/-   ##
==========================================
+ Coverage   69.76%   70.00%   +0.24%     
==========================================
  Files         430      430              
  Lines       47632    47632              
==========================================
+ Hits        33229    33347     +118     
+ Misses      11662    11534     -128     
- Partials     2741     2751      +10     
Flag Coverage Δ
unittests 70.00% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@CabinfeverB CabinfeverB requested review from rleungx and removed request for disksing and Yisaer January 19, 2024 01:17
@rleungx
Copy link
Member

rleungx commented Jan 24, 2024

CI failed

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
}

func (c *getKV) Unary(ctx context.Context, cli *clientv3.Client) error {
_, err := cli.Get(ctx, "/test/0001", clientv3.WithPrefix())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the key can be cluster id or others that must exist in etcd.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay. But I also have an idea, which is to initialize some key values

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 26, 2024
@nolouch
Copy link
Contributor

nolouch commented Jan 26, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2024

This pull request has been accepted and is ready to merge.

Commit hash: c4227e1

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0d10882 into tikv:master Jan 26, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make bench tools more powerful
3 participants