-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: API bench supports etcd #7715
Conversation
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7715 +/- ##
==========================================
+ Coverage 69.76% 70.00% +0.24%
==========================================
Files 430 430
Lines 47632 47632
==========================================
+ Hits 33229 33347 +118
+ Misses 11662 11534 -128
- Partials 2741 2751 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
CI failed |
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
} | ||
|
||
func (c *getKV) Unary(ctx context.Context, cli *clientv3.Client) error { | ||
_, err := cli.Get(ctx, "/test/0001", clientv3.WithPrefix()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the key can be cluster id or others that must exist in etcd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay. But I also have an idea, which is to initialize some key values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: c4227e1
|
What problem does this PR solve?
Issue Number: Close #7703
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note