-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http/client, test: remove IgnoreTopFunction of go leak and repair http SDK leak #7749
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7749 +/- ##
==========================================
- Coverage 73.87% 69.98% -3.90%
==========================================
Files 430 430
Lines 47630 47637 +7
==========================================
- Hits 35188 33338 -1850
- Misses 9454 11538 +2084
+ Partials 2988 2761 -227
Flags with carried forward coverage won't be shown. Click here to find out more. |
fbbeddb
to
1f20d47
Compare
/check-issue-triage-complete |
1f20d47
to
cdc4a1e
Compare
client/http/client.go
Outdated
// only close the service discovery if it's created by the client. | ||
if c.defaultSD && c.inner.sd != nil { | ||
c.inner.sd.Close() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about wrapping the defaultSD
into the inner client and providing a method to close sd
if necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved defaultSD
into inner
I don't think it seems necessary to provide a function
- For default creation, there is no need for user to care about close sd
- For incoming sd creation, it should be left to the higher level to do the closing.
Signed-off-by: husharp <jinhao.hu@pingcap.com>
/merge |
@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d7b0c25
|
What problem does this PR solve?
Issue Number: Close #7750
What is changed and how does it work?
Check List
Tests
Release note