Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/tso: add option useTSOServerProxy in pd-tso-bench #7756

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jan 25, 2024

What problem does this PR solve?

Issue Number: Ref #8135

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
Copy link
Contributor

ti-chi-bot bot commented Jan 25, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jan 25, 2024
@ti-chi-bot ti-chi-bot bot requested review from disksing and JmPotato January 25, 2024 06:54
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.40%. Comparing base (41e6376) to head (149ebc5).

Current head 149ebc5 differs from pull request most recent head 0d1d55b

Please upload reports for the commit 0d1d55b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7756      +/-   ##
==========================================
+ Coverage   77.25%   77.40%   +0.14%     
==========================================
  Files         470      470              
  Lines       61495    61365     -130     
==========================================
- Hits        47511    47497      -14     
+ Misses      10434    10306     -128     
- Partials     3550     3562      +12     
Flag Coverage Δ
unittests 77.40% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 20, 2024
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed do-not-merge/needs-linked-issue labels Jun 20, 2024
@HuSharp HuSharp changed the title tools: add option useTSOServerProxy in pd-tso-bench tools/tso: add option useTSOServerProxy in pd-tso-bench Jun 21, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 21, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: disksing, HuSharp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 21, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-20 05:36:38.28935357 +0000 UTC m=+265924.774842394: ☑️ agreed by disksing.
  • 2024-06-21 08:55:31.817048018 +0000 UTC m=+364258.302536845: ☑️ agreed by HuSharp.

Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2024

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 8215f30 into tikv:master Jun 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants