Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix region stats check (#7748) #7812

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7748

What problem does this PR solve?

Issue Number: Close #7728

What is changed and how does it work?

  1. isNew is useless because region source is inexact when leader transfer and no sync. Now, no need to hold isNew because saveCache must be true if the region in cache does not have leader.
  2. check whether the region is observed by its own map

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

close tikv#7728

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 9, 2024
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 9, 2024
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@CabinfeverB
Copy link
Member

wait for #7818

@CabinfeverB CabinfeverB force-pushed the cherry-pick-7748-to-release-7.5 branch from 893645f to 04a02a7 Compare February 10, 2024 12:27
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Merging #7812 (04a02a7) into release-7.5 (b8feb2b) will increase coverage by 0.04%.
The diff coverage is 95.83%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #7812      +/-   ##
===============================================
+ Coverage        74.49%   74.53%   +0.04%     
===============================================
  Files              444      444              
  Lines            48136    48140       +4     
===============================================
+ Hits             35857    35883      +26     
+ Misses            9086     9068      -18     
+ Partials          3193     3189       -4     
Flag Coverage Δ
unittests 74.53% <95.83%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@CabinfeverB
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 10, 2024

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 10, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 04a02a7

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3488a65 into tikv:release-7.5 Feb 10, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants