Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/heartbeat: support to collect metrics #8235

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented May 31, 2024

What problem does this PR solve?

Issue Number: Ref #8135

What is changed and how does it work?

tools/heartbeat: support to collect metrics
[2024/06/03 17:43:42.829 +08:00] [INFO] [util.go:162] ["metrics collected"] [round=4] [metrics="[max cpu usage(%)] 423.3333333333 [max memory usage(G)] 5.0294342041 [max go routines] 672.0000000000 [99% Heartbeat Latency(ms)] 0.0027463236 [Avg Heartbeat Latency(ms)] 0.0001914771 [AsyncHotStatsDuration] 0.1390788685 [CollectRegionStats] 0.0004269015 [Other] 0.3516389173 [PreCheck] 0.1390788685 [RegionGuide] 0.0041669604 [SaveCache_CheckOverlaps] 0.2434654559 [SaveCache_InvalidRegion] 0.0001080596 [SaveCache_SetRegion] 0.0080712888 [SaveCache_UpdateSubTree] 0.0027561614 "]
[2024/06/03 17:43:42.835 +08:00] [INFO] [main.go:648] ["update speed of each category"] [rps=193556.5518] [save-tree=11613.3931] [save-kv=0.0000] [save-space=0.0000] [save-flow=0.0000] [skip=181943.1587]
[2024/06/03 17:43:42.981 +08:00] [INFO] [main.go:560] ["region heartbeat stats"] [total=5.1663s] [slowest=2.9141s] [fastest=0.0000s] [average=1.3855s] [stddev=0.8114s] [rps=193561.3225] [max-epoch-version=1]
[2024/06/03 17:43:42.981 +08:00] [INFO] [main.go:562] ["store heartbeat stats"] [max=5.1664s]
[2024/06/03 17:44:37.663 +08:00] [INFO] [util.go:218] ["final metrics collected"] [total=9.7689s] [slowest=9.2799s] [fastest=0.0000s] [average=4.3321s] [stddev=2.7548s] [rps=117480.8411] ["avg store time"=9.7688943294] [metrics="[max cpu usage(%)] 423.3333333333 [max memory usage(G)] 5.0294342041 [max go routines] 672.0000000000 [99% Heartbeat Latency(ms)] 0.0027463236 [Avg Heartbeat Latency(ms)] 0.0001914771 [AsyncHotStatsDuration] 0.1390788685 [CollectRegionStats] 0.0004269015 [Other] 0.3516389173 [PreCheck] 0.1390788685 [RegionGuide] 0.0041669604 [SaveCache_CheckOverlaps] 0.2434654559 [SaveCache_InvalidRegion] 0.0001080596 [SaveCache_SetRegion] 0.0080712888 [SaveCache_UpdateSubTree] 0.0027561614 "]

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp requested review from nolouch and rleungx May 31, 2024 10:05
Copy link
Contributor

ti-chi-bot bot commented May 31, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.45%. Comparing base (11da622) to head (b0c2cbe).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8235      +/-   ##
==========================================
+ Coverage   77.35%   77.45%   +0.10%     
==========================================
  Files         472      472              
  Lines       61799    61802       +3     
==========================================
+ Hits        47803    47870      +67     
+ Misses      10432    10362      -70     
- Partials     3564     3570       +6     
Flag Coverage Δ
unittests 77.45% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-29 03:36:32.124982902 +0000 UTC m=+154108.405030973: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot added the approved label Jul 29, 2024
@nolouch nolouch added the lgtm label Jul 29, 2024
@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Jul 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 5d77447 into tikv:master Jul 29, 2024
23 of 25 checks passed
@HuSharp HuSharp deleted the support_hb_metrics branch July 29, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants